Allow ActiveRecordStore.session_class to be evaluated lazily#208
Open
gmcgibbon wants to merge 1 commit intorails:masterfrom
Open
Allow ActiveRecordStore.session_class to be evaluated lazily#208gmcgibbon wants to merge 1 commit intorails:masterfrom
gmcgibbon wants to merge 1 commit intorails:masterfrom
Conversation
Prevents Active Record from being loaded early in an initializer (where the session_class is being set. This can slow down application boot time.
d2d7c38 to
825f9c3
Compare
Member
|
Hum, how does this work with reloading? Isn't the solution to set it in |
Member
Author
|
Right, I think we would still need to use |
Member
Then: ActiveSupport.on_load(:active_record) do
config.to_prepare do
# ....
end
endOr am I missing something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents Active Record from being loaded early in an initializer (where the session_class is being set. This can slow down application boot time.