Skip to content

Workflow of python-zeroconf not valid for accepting external Pull Request contributions #1668

@eshattow

Description

@eshattow

Hi, I am submitting a PR and on acceptance the workflow fails. I am not a GitHub expert and so I do not know what to suggest to fix this.

I tried to adjust that ref as such:

--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -135,7 +135,7 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v4
         with:
           fetch-depth: 0
-          ref: ${{ github.head_ref || github.ref_name }}
+          ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}

and the job proceeds then failing at the Test Release:


$> /opt/psr/.venv/bin/semantic-release -v --noop version
🛡 You are running in no-operation mode, because the '--noop' flag was supplied
[08:13:26] INFO     Loading configuration from pyproject.toml         util.py:77
Detached HEAD state cannot match any release groups; no release will be made

Related: #1666 Bluetooth-Devices/dbus-fast#622

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions