Skip to content

add per-frame shift calculation for tiling-based multiview lateral registration#934

Open
barentine wants to merge 10 commits into
python-microscopy:masterfrom
barentine:tilereg
Open

add per-frame shift calculation for tiling-based multiview lateral registration#934
barentine wants to merge 10 commits into
python-microscopy:masterfrom
barentine:tilereg

Conversation

@barentine
Copy link
Copy Markdown
Member

Addresses issue #bead sparsity/density

Is this a bugfix or an enhancement?
enhancement
Proposed changes:

  • add points.multiview.raw_shifts_by_frame to calculate shifts between points on the same frame only
  • use raw_shifts_by_frame to generate a shiftmap if the recipe module is configured so

Notes:

Checklist:

  • Tested with numpy=1.14
  • Tested on python 2.7 and 3.6
  • Tested with wx=3.x and wx=4.x [if UI code]
  • Does the PR avoid variable renaming in existing code, whitespace changes, and other forms of tidying? [There is a place for code tidying, but it makes reviewing
    much simpler if this is kept separate from functional changes]

If an enhancement (or non-trivial bugfix):

  • Has this been discussed in advance (feature request, PR proposal, email, or direct conversation)?
  • Does this change how users interact with the software? How will these changes be communicated?
  • Does this maintain backwards compatibility with old data?
  • Does this change the required dependencies?
  • Are there any other side effects of the change?

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 7, 2021

Codecov Report

Merging #934 (a8c2e1a) into master (b0e1830) will decrease coverage by 0.00%.
The diff coverage is 2.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   11.29%   11.29%   -0.01%     
==========================================
  Files         626      626              
  Lines       72083    72138      +55     
==========================================
+ Hits         8142     8147       +5     
- Misses      63941    63991      +50     
Impacted Files Coverage Δ
PYME/Analysis/points/multiview.py 18.80% <2.38%> (-3.60%) ⬇️
PYME/recipes/multiview.py 33.51% <3.33%> (-1.92%) ⬇️
PYME/localization/FitFactories/InterpFitR.py 80.90% <0.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e1830...a8c2e1a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant