Note these changes are not strictly backwards compatible, but as the webui is strictly alpha, that probably doesn't matter.

Codecov Report

Merging #799 (96016c0) into master (b0e1830) will decrease coverage by 0.00%.
The diff coverage is 1.43%.

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   11.29%   11.28%   -0.01%     
==========================================
  Files         626      626              
  Lines       72083    72180      +97     
==========================================
+ Hits         8142     8147       +5     
- Misses      63941    64033      +92     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e1830...96016c0. Read the comment docs.

@barentine - this is ready to merge, and should address #902 as well. The one caveat is that it will likely require a change to recipes which queue acquisitions (due to the new parameterisation of SpoolControler.start_spooling() and, as a consequence actions.SpoolSeries). Holding off until you've given it a glance.

Main change is that start_spooling() and SpoolSeries now take all the series settings in a settings dict rather than as individual parameters. Rationale behind this is to permit them to be passed in the body of a REST request, and as a consequence support non-string typed parameters. Changing recipes should be pretty simple.

Cool, thanks for pushing on this @David-Baddeley and for flagging me to change my recipes. I'd say go ahead and merge - I'll keep you posted if I run into anything.

I notice you dropped the subdirectory and extra_metadata docstrings. Not sure if this was intentional - I know you aren't a big fan of either of them, but I think it's generally more helpful if you write that you don't like it but leave the doc, otherwise we just end up with more undocumented functionality to break or duplicate later

The doc changes were not intentional - likely a result of having initially not included them in the unifiedsettings parameter.