Skip to content

Only create stack settings if there are stages attached to microscope…#733

Merged
David-Baddeley merged 2 commits into
python-microscopy:masterfrom
David-Baddeley:acquire-z-detection
Jan 12, 2021
Merged

Only create stack settings if there are stages attached to microscope…#733
David-Baddeley merged 2 commits into
python-microscopy:masterfrom
David-Baddeley:acquire-z-detection

Conversation

@David-Baddeley
Copy link
Copy Markdown
Contributor

Addresses issue #714.

Is this a bugfix or an enhancement?

Combination - should be a fix for #714, but also includes a bit of re-factoring to move logic out of the GUI.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 21, 2020

Codecov Report

Merging #733 (f1e38e2) into master (dadbcfe) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #733      +/-   ##
=========================================
- Coverage    8.39%   8.38%   -0.01%     
=========================================
  Files         850     850              
  Lines       98143   98157      +14     
=========================================
- Hits         8236    8230       -6     
- Misses      89907   89927      +20     
Impacted Files Coverage Δ
PYME/Acquire/ExecTools.py 0.00% <0.00%> (ø)
PYME/Acquire/acquire_server.py 0.00% <0.00%> (ø)
PYME/Acquire/microscope.py 0.00% <0.00%> (ø)
PYME/Acquire/ui/HDFSpoolFrame.py 0.00% <0.00%> (ø)
PYME/Acquire/ui/seqdialog.py 0.00% <ø> (ø)
PYME/Acquire/HTTPSpooler.py 57.14% <0.00%> (-24.49%) ⬇️
PYME/misc/pyme_zeroconf.py 67.36% <0.00%> (-4.87%) ⬇️
PYME/misc/sqlite_ns.py 69.86% <0.00%> (-2.74%) ⬇️
PYME/IO/testClusterSpooling.py 73.75% <0.00%> (-1.25%) ⬇️
PYME/Acquire/Spooler.py 71.07% <0.00%> (-0.83%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dadbcfe...a541b08. Read the comment docs.

@David-Baddeley David-Baddeley merged commit f793564 into python-microscopy:master Jan 12, 2021
@David-Baddeley David-Baddeley deleted the acquire-z-detection branch January 25, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] PYME acquisitions lacking a z-controller try to access it nevertheless

1 participant