fix hx/hy assignment regression for line profiles#1660
Open
barentine wants to merge 2 commits into
Open
Conversation
Contributor
|
I need to understand the implications of round vs floor a bit better. Naively I'd think the correct behaviour for square selections at least is probably floor on the top left and ceil on the bottom right. For lines we want the same behaviour for top left and bottom right (round, floor, or ceil) (but I'd like to avoid selection type logic if I can in anything but display). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses regression in arrayViewPanel (commit here) where hx, hy never get assigned for line profiles (width=1) .
Is this a bugfix or an enhancement?
bugfix
Proposed changes:
while

yields
There are some remaining quirks:
displayOptions.GetSliceSelectionreturning start, finish, and us calling things lx, hx is fairly misleading and requires a +1 for the finish to get the full extent.PYME.Analysis.profile_extraction import extract_profilewhen drawing along the edge of the frame.tested on
wxPython '4.2.5 msw (phoenix) wxWidgets 3.2.9'
python 3.11
Windows 11