Skip to content

add serial version of thorlabs elliptec control#1659

Merged
David-Baddeley merged 1 commit into
python-microscopy:masterfrom
barentine:serial_elliptec
Apr 23, 2026
Merged

add serial version of thorlabs elliptec control#1659
David-Baddeley merged 1 commit into
python-microscopy:masterfrom
barentine:serial_elliptec

Conversation

@barentine
Copy link
Copy Markdown
Member

The Thorlabs elliptec software is currently Windows-only, which tripped me up when trying to run one on an Ubuntu system. This is a serial version of the shim, using https://github.com/roesel/elliptec .

Is this a bugfix or an enhancement?
enhancement
Proposed changes:

  • add a serial version of the thorlabs elliptec stage control
  • add both the thorlabs elliptec stage control files to the meson build sources so we can import in init scripts

Checklist:
The below is a list of things what will be considered when reviewing PRs. It is not prescriptive, and does not
imply that PRs which touch any of these will be rejected but gives a rough indication of where there is a potential
for hangups (i.e. factors which could turn a 5 min review into a half hour or longer and shunt it to the bottom
of the TODO list).

  • Does the PR avoid variable renaming in existing code, whitespace changes, and other forms of tidying? [There is a place for code tidying, but it makes reviewing
    much simpler if this is kept separate from functional changes. The auto-formatting performed by some editors is particulaly egregious and can lead to files with thousands
    of non-functional changes with a few functional changes scattered amoungst them]

If an enhancement (or non-trivial bugfix):

  • Has this been discussed in advance (feature request, PR proposal, email, or direct conversation)?
  • Does this change how users interact with the software? How will these changes be communicated?
  • Does this maintain backwards compatibility with old data?
  • Does this change the required dependencies?
  • Are there any other side effects of the change?

@David-Baddeley David-Baddeley merged commit ae98af0 into python-microscopy:master Apr 23, 2026
6 checks passed
@David-Baddeley
Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants