You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Addresses issue potential PYME user interested in different UI than our wx-based UI. They are interested in software development, so I wanted to show them and others what we already have in the space of an alternative UI.
Is this a bugfix or an enhancement?
enhancement Proposed changes:
add page on acquire server / web ui
link from PYMEAcquire basic usage page
Checklist:
The below is a list of things what will be considered when reviewing PRs. It is not prescriptive, and does not
imply that PRs which touch any of these will be rejected but gives a rough indication of where there is a potential
for hangups (i.e. factors which could turn a 5 min review into a half hour or longer and shunt it to the bottom
of the TODO list).
Does the PR avoid variable renaming in existing code, whitespace changes, and other forms of tidying? [There is a place for code tidying, but it makes reviewing
much simpler if this is kept separate from functional changes. The auto-formatting performed by some editors is particulaly egregious and can lead to files with thousands
of non-functional changes with a few functional changes scattered amoungst them]
If an enhancement (or non-trivial bugfix):
Has this been discussed in advance (feature request, PR proposal, email, or direct conversation)?
Does this change how users interact with the software? How will these changes be communicated?
Does this maintain backwards compatibility with old data?
I realise this is dear to your heart, but I wonder if we are jumping the gun a bit here (particularly with linking the web UI from the main PYMEAcquire docs). The Web UI as it stands is not really functional, and is likely to be a source of immense frustration for anyone who tries to use it.
I'll have a look to see how we can incorporate it - maybe, e.g. under a Future directions heading rather than the current Changing the UI heading.
Sounds good, @David-Baddeley . All fair points. Future directions would make more sense, probably, particularly for folks excited by it who want to get involved
also just a note that once #1461 is merged, PYMEAcquire -s will launch the PYMEAcquire normally, but with the server running at the same time. PYMEAcquire -s -b will launch the browser interface as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue potential PYME user interested in different UI than our wx-based UI. They are interested in software development, so I wanted to show them and others what we already have in the space of an alternative UI.
Is this a bugfix or an enhancement?
enhancement
Proposed changes:
Checklist:
The below is a list of things what will be considered when reviewing PRs. It is not prescriptive, and does not
imply that PRs which touch any of these will be rejected but gives a rough indication of where there is a potential
for hangups (i.e. factors which could turn a 5 min review into a half hour or longer and shunt it to the bottom
of the TODO list).
much simpler if this is kept separate from functional changes. The auto-formatting performed by some editors is particulaly egregious and can lead to files with thousands
of non-functional changes with a few functional changes scattered amoungst them]
If an enhancement (or non-trivial bugfix):