Add class to wrap multiaxis controllers to mimic single-axis piezo object#1368
Merged
David-Baddeley merged 2 commits intoJun 15, 2023
Merged
Conversation
…existing code that acts like a controller is single axis
Contributor
|
Seems reasonable, only potential critique is that class name is a bit verbose - I wonder if it makes sense to change to, e.g. |
Member
Author
|
I'm good with that. Changed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some existing code e.g. focus lock code is currently configured for a single-axis PiezoBase object. This
SingleAxisOnMultiaxisControlleris essentially a shim to wrap a given axis of an initialized multiaxis controller as a single axis PiezoBase. This lets one use the focus lock code as normal even if your z axis is controlled by a 3-axis stage.Is this a bugfix or an enhancement?
enhancement