Skip to content

fix remaining str/byte issue - byte encode/decode fix in event viewer #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csoeller wants to merge 1 commit into from
Closed

fix remaining str/byte issue - byte encode/decode fix in event viewer #1174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions PYME/DSView/eventLogViewer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,13 @@ def DoPaint(self, dc):
cmapping = c[1]
sourceEv = c[2]

# this was done above in another chart loop but omitted here
# QUESTION: isn't there a better solution to the byte/string handling of event logs
# that is more transparent and less error prone than this encode/decode hacking?
# we also have the byte literal quotes in the event log viewer this way (which is not necessarily pretty)
if not isinstance(sourceEv, bytes):
sourceEv = sourceEv.encode()

dc.SetTextForeground(self.lineColours[sourceEv])

dc.DrawText(cname, x4 + chartWidth/2 - dc.GetTextExtent(cname)[0]/2, 0)
Expand Down