Skip to content

ref(tox-config): migrate tox config from tox.ini to pyproject.toml - #700

Merged
patkan merged 16 commits into
python-escpos:masterfrom
hasansezertasan:migrate/tox-config
Jul 27, 2026
Merged

ref(tox-config): migrate tox config from tox.ini to pyproject.toml#700
patkan merged 16 commits into
python-escpos:masterfrom
hasansezertasan:migrate/tox-config

Conversation

@hasansezertasan

Copy link
Copy Markdown
Contributor

Related to #698

Description

Move tox configuration to pyproject.toml file.

@hasansezertasan

Copy link
Copy Markdown
Contributor Author

I am not sure how to move tox-gh-actions specific configurations to pyproject.toml. Does anyone have an idea?


I also wonder, why do we need it? What would happen if we just didn't use it? I would be very happy if you can help me with this one @patkan 🫶.

Comment thread pyproject.toml Outdated
Co-authored-by: Benito López <belono@users.noreply.github.com>
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
@codecov

codecov Bot commented Sep 1, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.13%. Comparing base (2ee1b3f) to head (a51e59d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #700      +/-   ##
==========================================
- Coverage   83.12%   79.13%   -4.00%     
==========================================
  Files          21       21              
  Lines        1754     1754              
  Branches      272      243      -29     
==========================================
- Hits         1458     1388      -70     
- Misses        213      285      +72     
+ Partials       83       81       -2     
Flag Coverage Δ
unittests 79.13% <ø> (-3.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pyproject.toml Outdated
Co-authored-by: Benito López <belono@users.noreply.github.com>
Comment thread tox.ini
@hasansezertasan

Copy link
Copy Markdown
Contributor Author

I found this package called tox-gh, by the @tox-dev team. WDYT about using it instead of tox-gh-actions?

Comment thread pyproject.toml
@hasansezertasan

hasansezertasan commented Sep 7, 2025

Copy link
Copy Markdown
Contributor Author

All checks are green now, let me know if any updates are required. @belono, and thank you for all the reviews 🙏.

@hasansezertasan
hasansezertasan marked this pull request as ready for review September 7, 2025 22:04

@belono belono left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing more to say but... great job! 👍

@patkan
patkan merged commit 07be3dd into python-escpos:master Jul 27, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants