This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Add timeout constructor parameter for use in HTTPClient operations#103
Closed
mwicat wants to merge 1 commit into
Closed
Add timeout constructor parameter for use in HTTPClient operations#103mwicat wants to merge 1 commit into
mwicat wants to merge 1 commit into
Conversation
Author
|
Aw, looks that this already in progress at #93 . Closing then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We would like to use this module in django project (for filling settings on startup), yet we cannot afford any delay on boot, so I added support for requests' timeout parameter. Would you like to merge it?
Sample usage:
start test server that will timeout when client connects:
run code that will throw timeout after 5 seconds: