Skip to content

gh-97850: Deprecate find_loader and get_loader in pkgutil #98520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettcannon merged 14 commits into from
May 3, 2023
Merged

gh-97850: Deprecate find_loader and get_loader in pkgutil #98520

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b7de6df
gh-97850: Deprecate `find_module` and `get_module` in `pkgutil`
sobolevn Oct 21, 2022
b1e6d4d
Address review
sobolevn Nov 9, 2022
d55a9b7
Update Misc/NEWS.d/next/Library/2022-10-21-16-23-31.gh-issue-97850.N4…
sobolevn Nov 9, 2022
e282911
Use just one module
sobolevn Nov 26, 2022
4f9a697
Merge branch 'deprecate-pkgutil-get-find-loader' of https://github.co…
sobolevn Nov 26, 2022
4222f23
Merge branch 'main' into deprecate-pkgutil-get-find-loader
brettcannon Jan 21, 2023
817f2da
Apply suggestions from code review
sobolevn Feb 5, 2023
8b116d9
Update Misc/NEWS.d/next/Library/2022-10-21-16-23-31.gh-issue-97850.N4…
sobolevn Feb 5, 2023
e94a6f3
Merge branch 'main' into deprecate-pkgutil-get-find-loader
sobolevn Apr 11, 2023
e073fac
Mention deprecation in `pkgutil` docs
sobolevn Apr 19, 2023
1e26981
Address review
sobolevn Apr 19, 2023
24badea
Merge branch 'main' into deprecate-pkgutil-get-find-loader
arhadthedev Apr 30, 2023
619c4dc
Apply suggestions from code review
brettcannon May 3, 2023
b65576a
Merge branch 'main' into deprecate-pkgutil-get-find-loader
sobolevn May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into deprecate-pkgutil-get-find-loader
  • Loading branch information
@arhadthedev
arhadthedev authored Apr 30, 2023
commit 24badea5a2b4fe523b25f84812250a64ea25698b
8 changes: 0 additions & 8 deletions Lib/test/test_pkgutil.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,14 +541,6 @@ def check_deprecated(self):
"Python 3.12; use 'importlib' instead",
DeprecationWarning))

def test_importer_deprecated(self):
with self.check_deprecated():
pkgutil.ImpImporter("")

def test_loader_deprecated(self):
with self.check_deprecated():
pkgutil.ImpLoader("", "", "", "")

@unittest.skipIf(__name__ == '__main__', 'not compatible with __main__')
@ignore_warnings(category=DeprecationWarning)
def test_get_loader_handles_missing_loader_attribute(self):
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.