Skip to content

GH-96793: Change FOR_ITER to not pop the iterator on exhaustion. #96801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 12 commits into from
Oct 27, 2022
Merged

GH-96793: Change FOR_ITER to not pop the iterator on exhaustion. #96801

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bf44755
Modify FOR_ITER to leave iterator on stack. Work in progress.
markshannon Sep 8, 2022
5bdef2b
Document change to FOR_ITER.
markshannon Sep 9, 2022
5250ffc
Merge branch 'main' into for-iter-no-pop
markshannon Sep 13, 2022
b807ef8
Add news.
markshannon Sep 13, 2022
d5dd9b4
Skip over POP_TOP at end of loop in specialized versions of FOR_ITER.
markshannon Oct 21, 2022
c9ff8b7
Merge branch 'main' into for-iter-no-pop
markshannon Oct 25, 2022
c5e9d2c
Fix up new POP_TOPs to have no location.
markshannon Oct 25, 2022
687833a
Merge branch 'main' into for-iter-no-pop
markshannon Oct 26, 2022
a575fc8
Add END_FOR instruction
markshannon Oct 26, 2022
63bd124
Fix up specialization of FOR_ITER
markshannon Oct 26, 2022
611685f
Fix tests
markshannon Oct 26, 2022
b6086b6
Add END_FOR to docs.
markshannon Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Document change to FOR_ITER.
  • Loading branch information
@markshannon
markshannon committed Sep 9, 2022
commit 5bdef2b6189917632cc2c3be1f78341a4090f980
4 changes: 3 additions & 1 deletion Doc/library/dis.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,9 +1068,11 @@ iterations of the loop.

TOS is an :term:`iterator`. Call its :meth:`~iterator.__next__` method. If
this yields a new value, push it on the stack (leaving the iterator below
it). If the iterator indicates it is exhausted, TOS is popped, and the byte
it). If the iterator indicates it is exhausted then the byte
code counter is incremented by *delta*.

.. versionchanged:: 3.12
Up until 3.11 the iterator was popped when it was exhausted.

.. opcode:: LOAD_GLOBAL (namei)

Expand Down