Skip to content

gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails #95264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 5 commits into from
Jul 26, 2022
+7 −1
Merged

gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails #95264

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8210ab3
gh-95041: fail syslog.syslog in case inner call to syslog.openlog fails
noamcohen97 Jul 26, 2022
c95b55c
return null if `PyTuple_New()` fails on syslog.syslog
noamcohen97 Jul 26, 2022
9813348
avoid using a pointer to freed memory on syslog.syslog
noamcohen97 Jul 26, 2022
b507a03
syslog.syslog: nicer error handling
noamcohen97 Jul 26, 2022
5a097a6
Update Modules/syslogmodule.c
noamcohen97 Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
syslog.syslog: nicer error handling
  • Loading branch information
@noamcohen97
noamcohen97 committed Jul 26, 2022
commit b507a03c63064885f3c1d3e447577f3788595492
5 changes: 2 additions & 3 deletions Modules/syslogmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,10 @@ syslog_syslog(PyObject * self, PyObject * args)
if ((openargs = PyTuple_New(0))) {
Comment thread
noamcohen97 marked this conversation as resolved.
PyObject *openlog_ret = syslog_openlog(self, openargs, NULL);
Py_DECREF(openargs);
if (openlog_ret != NULL) {
Py_DECREF(openlog_ret);
} else {
if (openlog_ret == NULL) {
return NULL;
}
Py_DECREF(openlog_ret);
} else {
Comment thread
noamcohen97 marked this conversation as resolved.
Outdated
return NULL;
}
Expand Down