Skip to content

bpo-33237: Improve AttributeError message for partially initialized module. #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 11 commits into from
Oct 30, 2018
Merged

bpo-33237: Improve AttributeError message for partially initialized module. #6398

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8684e59
bpo-33237: Improve AttributeError message for partially initialized m…
serhiy-storchaka Apr 6, 2018
b072b9b
Update error message.
serhiy-storchaka Apr 6, 2018
770f2f5
Add _PyModule_IsInitializing().
serhiy-storchaka Jul 24, 2018
8df6406
Add a news entry.
serhiy-storchaka Jul 24, 2018
4c2dea3
Refactoring.
serhiy-storchaka Jul 28, 2018
86eb2c8
Merge branch 'master' into mod-attr-error
serhiy-storchaka Oct 20, 2018
b43863f
Merge branch 'master' into mod-attr-error
serhiy-storchaka Oct 20, 2018
9f37fba
Restore support of non-module subclasses in PyImport_ImportModuleLeve…
serhiy-storchaka Oct 20, 2018
1bd96f9
Add tests.
serhiy-storchaka Oct 21, 2018
9a78720
Remove redundant condition and add a comment.
serhiy-storchaka Oct 29, 2018
d08f64d
Merge branch 'master' into mod-attr-error
serhiy-storchaka Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Oct 21, 2018
commit 1bd96f9292bf1745596b0aaead00b7ad712f4425
13 changes: 13 additions & 0 deletions Lib/test/test_import/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,6 +1271,19 @@ def test_binding(self):
except ImportError:
self.fail('circular import with binding a submodule to a name failed')

def test_crossreference1(self):
import test.test_import.data.circular_imports.use
import test.test_import.data.circular_imports.source

def test_crossreference2(self):
with self.assertRaises(AttributeError) as cm:
import test.test_import.data.circular_imports.source
errmsg = str(cm.exception)
self.assertIn('test.test_import.data.circular_imports.source', errmsg)
self.assertIn('spam', errmsg)
self.assertIn('partially initialized module', errmsg)
self.assertIn('circular import', errmsg)


if __name__ == '__main__':
# Test needs to be a package, so we can do relative imports.
Expand Down
2 changes: 2 additions & 0 deletions Lib/test/test_import/data/circular_imports/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import use
spam = 1
2 changes: 2 additions & 0 deletions Lib/test/test_import/data/circular_imports/use.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import source
source.spam