Skip to content

bpo-46841: Use inline caching for attribute accesses #31640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 12 commits into from
Mar 3, 2022
Merged

bpo-46841: Use inline caching for attribute accesses #31640

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c2b0713
Use inline caching for attribute accesses
brandtbucher Mar 2, 2022
2d5e15a
Bump magic number
brandtbucher Mar 2, 2022
5b06d97
blurb add
brandtbucher Mar 2, 2022
828540a
Clean things up a bit
brandtbucher Mar 2, 2022
4a6632c
Catch up with main
brandtbucher Mar 2, 2022
2b876f1
Fix typo
brandtbucher Mar 2, 2022
097fdaf
Apply feedback from code review
brandtbucher Mar 3, 2022
4c71c12
Get rid of LOAD_FAST__LOAD_ATTR_INSTANCE_VALUE
brandtbucher Mar 3, 2022
09fbac5
Remove workaround
brandtbucher Mar 3, 2022
e5229ce
Fix typo
brandtbucher Mar 3, 2022
452c78c
SIZEOF_UINTPTR_T isn't defined on Windows
brandtbucher Mar 3, 2022
948a206
Fix version number
brandtbucher Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SIZEOF_UINTPTR_T isn't defined on Windows
  • Loading branch information
@brandtbucher
brandtbucher committed Mar 3, 2022
commit 452c78ccd2a41d76039eadf51e1f164b0e14ed62
12 changes: 6 additions & 6 deletions Include/internal/pycore_code.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,25 +509,25 @@ static inline void
write_obj(uint16_t *p, PyObject *obj)
{
uintptr_t val = (uintptr_t)obj;
#if SIZEOF_UINTPTR_T == 8
#if SIZEOF_VOID_P == 8
write_u64(p, val);
#elif SIZEOF_UINTPTR_T == 4
#elif SIZEOF_VOID_P == 4
write_u32(p, val);
#else
#error "sizeof(uintptr_t) must be 4 or 8"
#error "SIZEOF_VOID_P must be 4 or 8"
#endif
}

static inline PyObject *
read_obj(uint16_t *p)
{
uintptr_t val;
#if SIZEOF_UINTPTR_T == 8
#if SIZEOF_VOID_P == 8
val = read_u64(p);
#elif SIZEOF_UINTPTR_T == 4
#elif SIZEOF_VOID_P == 4
val = read_u32(p);
#else
#error "sizeof(uintptr_t) must be 4 or 8"
#error "SIZEOF_VOID_P must be 4 or 8"
#endif
return (PyObject *)val;
}
Expand Down