Skip to content

bpo-31061: fix crash in asyncio speedup module #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 18 commits into from
Aug 2, 2017
Merged

bpo-31061: fix crash in asyncio speedup module #2966

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
336a6ce
attempt to fix http://bugs.python.org/issue31061
thehesiod Aug 1, 2017
4fd34a6
fix typo
thehesiod Aug 1, 2017
97ccf31
fix capitalization
thehesiod Aug 1, 2017
a67847e
switch to private version
thehesiod Aug 1, 2017
e126945
undo :)
thehesiod Aug 1, 2017
de3ee01
add missing untrack
thehesiod Aug 1, 2017
6a02050
revert change
thehesiod Aug 1, 2017
503806f
add news item
thehesiod Aug 1, 2017
f900058
simplify patch based on review
thehesiod Aug 1, 2017
483586b
remove
thehesiod Aug 1, 2017
b4589ce
add blurb
thehesiod Aug 1, 2017
fa2b42b
remove space
thehesiod Aug 1, 2017
3ca521d
revert
thehesiod Aug 1, 2017
b0fb8e7
new task test case
thehesiod Aug 1, 2017
f32e949
fix unittest
thehesiod Aug 1, 2017
7bc0c2a
set the loop
thehesiod Aug 1, 2017
55a2eb5
fix off by one paren error :)
thehesiod Aug 1, 2017
3033b15
fix ordering
thehesiod Aug 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix ordering
  • Loading branch information
@thehesiod
thehesiod committed Aug 1, 2017
commit 3033b1504648ea85a667b01103ea31b8396033b8
2 changes: 1 addition & 1 deletion Lib/test/test_asyncio/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
import collections
import contextlib
import functools
import io
import gc
Copy link
Copy Markdown
Member

@1st1 1st1 Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nit: 'gc' import should be before 'functools' -- we sort imports alphabetically in CPython.

Copy link
Copy Markdown
Contributor Author

@thehesiod thehesiod Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be worth running a linter on CI to catch these

Copy link
Copy Markdown
Member

@1st1 1st1 Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, good idea. BTW help is always welcome by python/core-workflow. You're an awesome contributor, we'd love you to continue! :)

Copy link
Copy Markdown
Contributor Author

@thehesiod thehesiod Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're too kind :) Will keep that in mind if we run into any other cpython issues.

import io
import os
import re
import sys
Expand Down