Skip to content

bpo-45243: Expose SQLite connection limits as sqlite3.Connection attributes #28790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erlend-aasland wants to merge 5 commits into from
Closed

bpo-45243: Expose SQLite connection limits as sqlite3.Connection attributes #28790

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4b9fcd
bpo-45243: Add support for setting/getting sqlite3 connection limits
Oct 7, 2021
b4302fd
Reinterpret void pointer in a more compiler friendly way
Oct 7, 2021
dc8976b
Undef helper macro after use
Oct 7, 2021
a29499a
Add tests
Oct 7, 2021
d04794d
Add test_connection_limit_attributes
Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests
  • Loading branch information
Erlend E. Aasland committed Oct 7, 2021
commit a29499a2c1c7ad0522d8ca2be200c073810dd063
16 changes: 16 additions & 0 deletions Lib/sqlite3/test/test_dbapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,15 @@ def test_connection_limits(self):
finally: # restore old limit
self.cx.SQLITE_LIMIT_SQL_LENGTH = limit

def test_connection_delete_limit(self):
msg = "Cannot delete limit attributes"
with self.assertRaisesRegex(sqlite.ProgrammingError, msg):
del self.cx.SQLITE_LIMIT_LENGTH

def test_connection_bad_set_limit(self):
with self.assertRaises(TypeError):
self.cx.SQLITE_LIMIT_EXPR_DEPTH = "a"


class UninitialisedConnectionTests(unittest.TestCase):
def setUp(self):
Expand Down Expand Up @@ -771,6 +780,11 @@ def run(err):
self.fail("\n".join(err))

def test_check_connection_thread(self):
def set_cx_limit():
self.con.SQLITE_LIMIT_LENGTH = 0
def get_cx_limit():
return self.con.SQLITE_LIMIT_LENGTH

fns = [
lambda: self.con.cursor(),
lambda: self.con.commit(),
Expand All @@ -779,6 +793,8 @@ def test_check_connection_thread(self):
lambda: self.con.set_trace_callback(None),
lambda: self.con.set_authorizer(None),
lambda: self.con.create_collation("foo", None),
lambda: set_cx_limit(),
lambda: get_cx_limit(),
]
for fn in fns:
with self.subTest(fn=fn):
Expand Down