Skip to content

bpo-44050: Extension modules can share state when they don't support sub-interpreters. #27794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 5 commits into from
Oct 5, 2021
Merged

bpo-44050: Extension modules can share state when they don't support sub-interpreters. #27794

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ffadb4
Extension modules created from PyModule_Create() can share state
shihai1991 Aug 17, 2021
2d2165c
apply petr's comment
shihai1991 Aug 17, 2021
70b7861
apply victor's comment
shihai1991 Aug 21, 2021
d53e2dd
add a NEWS entry
shihai1991 Sep 7, 2021
eb9b40d
Update Misc/NEWS.d/next/Core and Builtins/2021-09-08-00-30-09.bpo-440…
encukou Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Extension modules created from PyModule_Create() can share state
  • Loading branch information
@shihai1991
shihai1991 committed Aug 17, 2021
commit 4ffadb4430b6cda726473b72c98bcd7c3b35a17f
4 changes: 3 additions & 1 deletion Python/import.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,9 @@ _PyImport_FixupExtensionObject(PyObject *mod, PyObject *name,
return -1;
}

if (_Py_IsMainInterpreter(tstate->interp)) {
// bpo-44050: Extensions and def->m_base.m_copy can be updated
// when extension module created from PyModule_Create().
if (_Py_IsMainInterpreter(tstate->interp) || def->m_slots == NULL) {
if (def->m_size == -1) {
if (def->m_base.m_copy) {
/* Somebody already imported the module,
Expand Down