Skip to content

bpo-38323: Change MultiLoopChildWatcher to install handlers for all the event loops #26574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shreyanavigyan wants to merge 9 commits into from
Closed

bpo-38323: Change MultiLoopChildWatcher to install handlers for all the event loops #26574

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
90c0e81
Fix the race condition
shreyanavigyan Jun 6, 2021
39e18a0
Fix a bug introduced in this patch
shreyanavigyan Jun 7, 2021
7807d79
Adjust comments and notes
shreyanavigyan Jun 7, 2021
b38bd27
Call remove_signal_handler in remove_child_handler
shreyanavigyan Jun 7, 2021
05d2263
Remove warning
shreyanavigyan Jun 7, 2021
7894fc7
Add news entry
shreyanavigyan Jun 7, 2021
e0f1788
Fix issues
shreyanavigyan Jun 7, 2021
c69acff
Fix news entry issue
shreyanavigyan Jun 7, 2021
27a4af3
Update
shreyanavigyan Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix news entry issue
  • Loading branch information
@shreyanavigyan
shreyanavigyan committed Jun 7, 2021
commit c69acff7b868b0fbc16c7d8bd47f4eb2f10b6f55
14 changes: 7 additions & 7 deletions Misc/NEWS.d/next/Library/2021-06-07-13-39-16.bpo-38323.FGViHn.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
Fix a race condition in `MultiLoopChildWatcher`. The patch does the
Fix a race condition in ``MultiLoopChildWatcher``. The patch does the
following -

1) Creates a list that will keep track of the event loops where the handler
has been installed by `MultiLoopChildWatcher`.
has been installed by ``MultiLoopChildWatcher``.

2) In `attach_loop` and `add_child_handler`, the handler is installed for the
loop using `add_signal_handler` and the event loop instance is also added to
2) In ``attach_loop`` and ``add_child_handler``, the handler is installed for the
loop using ``add_signal_handler`` and the event loop instance is also added to
the list.

3) In `remove_child_handler`, the `remove_signal_handler` is called on the
3) In ``remove_child_handler``, the ``remove_signal_handler`` is called on the
loop the provided pid is attached to.

4) In `close`, the `remove_signal_handler` is called on every loop and the
4) In ``close``, the ``remove_signal_handler`` is called on every loop and the
loop is removed from the list.

The patch changes the behavior of `MultiLoopChildWatcher`. `MultiLoopChildWatcher`
The patch changes the behavior of ``MultiLoopChildWatcher``. ``MultiLoopChildWatcher``
can now only be used in the main thread.

Patch by Shreyan Avigyan