Skip to content

bpo-44002: Switch to lru_cache in urllib.parse. #25798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 7 commits into from
May 12, 2021
+50 −31
Merged

bpo-44002: Switch to lru_cache in urllib.parse. #25798

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
630dd0a
bpo-44002: Switch to lru_cache in urllib.parse.
gpshead May 1, 2021
7397c2c
Use the default lru_cache size.
gpshead May 2, 2021
8a54534
Use a typed lru_cache on urlsplit.
gpshead May 2, 2021
7b70e99
Restore the list comprehensions.
gpshead May 2, 2021
c2dbd84
don't deprecate clear_cache().
gpshead May 3, 2021
6c02506
Merge remote-tracking branch 'upstream/main' into non-90s-urlparse-cache
gpshead May 11, 2021
1129c9b
Add a test for the module level __getattr__().
gpshead May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore the list comprehensions.
  • Loading branch information
@gpshead
gpshead authored May 2, 2021
commit 7b70e99f80ce712650abc45fabf12326b7c22d69
5 changes: 3 additions & 2 deletions Lib/urllib/parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,11 +904,12 @@ def quote_from_bytes(bs, safe='/'):
# Normalize 'safe' by converting to bytes and removing non-ASCII chars
safe = safe.encode('ascii', 'ignore')
else:
safe = bytes(c for c in safe if c < 128)
# List comprehensions are faster than generator expressions.
safe = bytes([c for c in safe if c < 128])
if not bs.rstrip(_ALWAYS_SAFE_BYTES + safe):
return bs.decode()
quoter = _byte_quoter_factory(safe)
return ''.join(quoter(char_num) for char_num in bs)
return ''.join([quoter(char) for char in bs])

def urlencode(query, doseq=False, safe='', encoding=None, errors=None,
quote_via=quote_plus):
Expand Down