Skip to content

bpo-1635741: Port sha256 module to multiphase init (PEP 489) #21189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 4 commits into from
Jul 3, 2020
Merged

bpo-1635741: Port sha256 module to multiphase init (PEP 489) #21189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f9e45a
Port sha256 module to multi-phase init (PEP 489)
koubaa Jun 27, 2020
598fd1a
changes requested by review
koubaa Jul 2, 2020
5e716b5
fix compile issue
koubaa Jul 2, 2020
300b637
remove unneeded field inits
koubaa Jul 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changes requested by review
  • Loading branch information
@koubaa
koubaa committed Jul 2, 2020
commit 598fd1ad73b4b4259bebd7164760b3bbeaf1d86b
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2020-07-01-20-17-38.bpo-1635741.-AtPYu.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Port :mod:`sha256` to multiphase initialization
26 changes: 16 additions & 10 deletions Modules/sha256module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,9 +693,15 @@ static int sha256_exec(PyObject *module)
}

Py_INCREF((PyObject *)&SHA224type);
PyModule_AddObject(module, "SHA224Type", (PyObject *)&SHA224type);
if (PyModule_AddObject(module, "SHA224Type", (PyObject *)&SHA224type) < 0) {
Py_DECREF(PyObject *)&SHA224type);
return -1;
}
Py_INCREF((PyObject *)&SHA256type);
PyModule_AddObject(module, "SHA256Type", (PyObject *)&SHA256type);
if (PyModule_AddObject(module, "SHA256Type", (PyObject *)&SHA256type) < 0) {
Py_DECREF(PyObject *)&SHA256type);
return -1;
}
return 0;
}

Expand All @@ -706,14 +712,14 @@ static PyModuleDef_Slot _sha256_slots[] = {

static struct PyModuleDef _sha256module = {
Comment thread
koubaa marked this conversation as resolved.
PyModuleDef_HEAD_INIT,
"_sha256",
NULL,
0,
SHA_functions,
_sha256_slots,
NULL,
NULL,
NULL
.m_name = "_sha256",
.m_doc = NULL,
.m_size = 0,
.m_methods = SHA_functions,
.m_slots = _sha256_slots,
.m_traverse = NULL,
.m_clear = NULL,
.m_free = NULL
Comment thread
koubaa marked this conversation as resolved.
Outdated
};

/* Initialize this module. */
Expand Down