GH-144679: When building with VS2026 on Windows, use PlatformToolSet v145 by default #144680
+5
−2
Next
Next commit
Use PlatformToolSet v145 by default when building with VS 2026
Furthermore, do not warn anymore when building with v145
- Loading branch information
commit 839e029fad5709e1a15523b4ffb5c493e5009317
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On main, shall we warn for older toolsets like
v141orv142now?Likewise, shall we keep a warning for
v145on 3.13 / 3.14?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minimum VS version for building Python now is 2017.
https://docs.python.org/3.15/using/configure.html
I removed the support for 2015 a year ago #124103 . However, according to the Mainstream End Date of the VS lifecycle, currently only VS2022 is still supported
https://learn.microsoft.com/lifecycle/products/visual-studio-2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's start warning for those older ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should change that to 2022 since we emit a warning for the older ones now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not required though, whereas I'm pretty sure we made changes that prevent using the compilers that came with VS 2015. If you want to write something that's clearer about the "works with" toolset version, the "released/supported with" toolset versions, and the VS versions that typically include these toolsets (newer VS should have older MSVC available as options, but not selected by default), feel free.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it now, thanks for the explanation. So no need to change that from my point of view, until in the future we do a change that requires a newer version than VS 2017.