Skip to content

gh-136186: Fix more flaky tests in test_external_inspection #143235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Dec 28, 2025
Merged

gh-136186: Fix more flaky tests in test_external_inspection #143235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-136186: Fix more flaky tests in test_external_inspection
  • Loading branch information
@pablogsal
pablogsal committed Dec 28, 2025
commit 323ecfd60ae45b90bee633c73b60f9ba2118b276
7 changes: 6 additions & 1 deletion Lib/test/test_external_inspection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1752,7 +1752,12 @@ def main_work():
unwinder_gil = RemoteUnwinder(
p.pid, only_active_thread=True
)
gil_traces = _get_stack_trace_with_retry(unwinder_gil)
# Use condition to retry until we capture a thread holding the GIL
# (sampling may catch moments with no GIL holder on slow CI)
gil_traces = _get_stack_trace_with_retry(
unwinder_gil,
condition=lambda t: sum(len(i.threads) for i in t) >= 1,
)

# Count threads
total_threads = sum(
Expand Down
Loading