Skip to content

GH-139653: Only raise an exception (or fatal error) when the stack pointer is about to overflow the stack. #141711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 5 commits into from
Nov 19, 2025
+38 −10
Merged

GH-139653: Only raise an exception (or fatal error) when the stack pointer is about to overflow the stack. #141711

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41e9404
Only raise an exception (or fatal error) when the stack pointer is ab…
markshannon Nov 17, 2025
1e7ae53
Fix typo and clarify
markshannon Nov 18, 2025
1de4a56
A couple more typos
markshannon Nov 19, 2025
7dcdf04
Update comment
markshannon Nov 20, 2025
b28b230
Fix typos
markshannon Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment
  • Loading branch information
@markshannon
markshannon committed Nov 20, 2025
commit 7dcdf04d765d89437015109f11b4eb045de76764
2 changes: 1 addition & 1 deletion Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ PyUnstable_ThreadState_ResetStackProtection(PyThreadState *tstate)


/* The function _Py_EnterRecursiveCallTstate() only calls _Py_CheckRecursiveCall()
if the recursion_depth reaches recursion_limit. */
if the stack poineter is between the stack base and c_stack_hard_limit. */
Copy link
Copy Markdown
Member

@encukou encukou Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if the stack poineter is between the stack base and c_stack_hard_limit. */
if the stack pointer is between the stack base and c_stack_hard_limit. */

int
_Py_CheckRecursiveCall(PyThreadState *tstate, const char *where)
{
Expand Down