Skip to content

gh-141174: Improve annotationlib.call_annotate_function() test coverage #141176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 3 commits into from
Nov 10, 2025
+43 −0
Merged

gh-141174: Improve annotationlib.call_annotate_function() test coverage #141176

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06d8832
Test passing unsupported Format values to call_annotate_function()
dr-carlos Nov 6, 2025
3910c6e
Test call_evaluate_function with fake globals that raise errors
dr-carlos Nov 6, 2025
5d60170
Fix typo and comparison in test_fake_global_evaluation
dr-carlos Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo and comparison in test_fake_global_evaluation
  • Loading branch information
@dr-carlos
dr-carlos committed Nov 7, 2025
commit 5d601701a80179776b6136f762e7f6990dca20af
4 changes: 2 additions & 2 deletions Lib/test/test_annotationlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,15 +1257,15 @@ def evaluate_union(format, exc=NotImplementedError):

self.assertEqual(
annotationlib.call_evaluate_function(evaluate_union, Format.FORWARDREF),
support.EqualToForwardRef("builtins.undef | list[int]"),
support.EqualToForwardRef("builtins.undefined | list[int]"),
)

# This will raise an AttributeError
def evaluate_intermediate(format, exc=NotImplementedError):
if format == Format.VALUE_WITH_FAKE_GLOBALS:
intermediate = builtins.undefined
# Return a literal
return intermediate == builtins.defined
return intermediate is None
raise exc

self.assertIs(
Expand Down
Loading