Skip to content

gh-140513: Fail to compile if _Py_TAIL_CALL_INTERP is set but preserve_none and musttail do not exist. #140548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 9 commits into from
Nov 1, 2025
Merged

gh-140513: Fail to compile if _Py_TAIL_CALL_INTERP is set but preserve_none and musttail do not exist. #140548

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6812a5f
fix
XChaitanyaX Oct 24, 2025
d8901b1
add space after #endif
XChaitanyaX Oct 24, 2025
95e9b6f
unnecessary `!` mark
XChaitanyaX Oct 24, 2025
d4fa2e4
commit
XChaitanyaX Oct 24, 2025
96ff7b8
commit
XChaitanyaX Oct 24, 2025
e3893ac
blurb
XChaitanyaX Oct 25, 2025
2c36f5d
fix indent
XChaitanyaX Oct 25, 2025
db8f35c
indent
XChaitanyaX Oct 27, 2025
5fb8be8
modify news entry
XChaitanyaX Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add space after #endif
  • Loading branch information
@XChaitanyaX
XChaitanyaX committed Oct 24, 2025
commit d8901b1eb1b0fa15f2f97a001b371367de3507ec
1 change: 1 addition & 0 deletions Python/ceval_macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,11 @@
# error "This compiler does not have support for efficient tail calling."
# endif
#endif
Comment thread
XChaitanyaX marked this conversation as resolved.
Outdated

// Note: [[clang::musttail]] works for GCC 15, but not __attribute__((musttail)) at the moment.
# define Py_MUSTTAIL [[clang::musttail]]
# define Py_PRESERVE_NONE_CC __attribute__((preserve_none))
Py_PRESERVE_NONE_CC typedef PyObject* (*py_tail_call_funcptr)(TAIL_CALL_PARAMS);

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

'py_tail_call_funcptr': not in formal parameter list [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

function returns function [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

syntax error: missing ')' before 'type' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

syntax error: ')' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

syntax error: missing ')' before '(' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

'py_tail_call_funcptr': not in formal parameter list [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

function returns function [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

syntax error: missing ')' before 'type' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

syntax error: ')' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

syntax error: missing ')' before '(' [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

'py_tail_call_funcptr': not in formal parameter list [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

function returns function [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

syntax error: missing ')' before 'type' [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

syntax error: ')' [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

syntax error: missing ')' before '(' [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

'py_tail_call_funcptr': not in formal parameter list [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

function returns function [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

syntax error: missing ')' before 'type' [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

syntax error: ')' [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

syntax error: missing ')' before '(' [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check warning on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

‘preserve_none’ attribute directive ignored [-Wattributes]

Check warning on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

‘preserve_none’ attribute directive ignored [-Wattributes]

Check warning on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

‘preserve_none’ attribute directive ignored [-Wattributes]

Check warning on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

‘preserve_none’ attribute directive ignored [-Wattributes]

Check warning on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

‘preserve_none’ attribute directive ignored [-Wattributes]

Check warning on line 90 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

‘preserve_none’ attribute directive ignored [-Wattributes]

# define TARGET(op) Py_PRESERVE_NONE_CC PyObject *_TAIL_CALL_##op(TAIL_CALL_PARAMS)
# define DISPATCH_GOTO() \
Expand All @@ -109,19 +110,19 @@
} while (0)
# endif
# define LABEL(name) TARGET(name)
#elif USE_COMPUTED_GOTOS

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (x64) 

unexpected #elif [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (x64) 

unexpected #elif [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows / Build and test (arm64) 

unexpected #elif [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / Build and test (arm64) 

unexpected #elif [C:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

#elif without #if

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

#elif without #if

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

#elif without #if

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

#elif without #if

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

#elif without #if

Check failure on line 113 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

#elif without #if
# define TARGET(op) TARGET_##op:
# define DISPATCH_GOTO() goto *opcode_targets[opcode]
# define JUMP_TO_LABEL(name) goto name;
# define JUMP_TO_PREDICTED(name) goto PREDICTED_##name;
# define LABEL(name) name:
#else

Check failure on line 119 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

#else without #if

Check failure on line 119 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

#else without #if

Check failure on line 119 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

#else without #if

Check failure on line 119 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

#else without #if

Check failure on line 119 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

#else without #if

Check failure on line 119 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

#else without #if
# define TARGET(op) case op: TARGET_##op:

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

case label not within a switch statement

Check failure on line 120 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

case label not within a switch statement
# define DISPATCH_GOTO() goto dispatch_opcode
# define JUMP_TO_LABEL(name) goto name;
# define JUMP_TO_PREDICTED(name) goto PREDICTED_##name;
# define LABEL(name) name:
#endif

Check failure on line 125 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Cross build Linux 

#endif without #if

Check failure on line 125 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (free-threading) / build and test (ubuntu-24.04) 

#endif without #if

Check failure on line 125 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu / build and test (ubuntu-24.04-arm) 

#endif without #if

Check failure on line 125 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Address sanitizer (ubuntu-24.04) 

#endif without #if

Check failure on line 125 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Ubuntu (bolt) / build and test (ubuntu-24.04) 

#endif without #if

Check failure on line 125 in Python/ceval_macros.h

View workflow job for this annotation

GitHub Actions / Hypothesis tests on Ubuntu 

#endif without #if

/* PRE_DISPATCH_GOTO() does lltrace if enabled. Normally a no-op */
#ifdef Py_DEBUG
Expand Down
Loading