Skip to content

[3.14] gh-123828: Fix data race in _interpchannels._waiting_release (GH-124107) #139517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZeroIntensity merged 1 commit into from
Oct 7, 2025
+2 −3
Merged

[3.14] gh-123828: Fix data race in _interpchannels._waiting_release (GH-124107) #139517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-123828: Fix data race in _interpchannels._waiting_release (GH-12… 
…4107)

(cherry picked from commit f39dea3)

Co-authored-by: Nadeshiko Manju <me@manjusaka.me>
  • Loading branch information
@Zheaoli @miss-islington
Zheaoli authored and miss-islington committed Oct 2, 2025
commit 1f126237a0cd7540ab2b2a59c96904c509268a17
3 changes: 1 addition & 2 deletions Lib/test/test__interpchannels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import time
import unittest

from test.support import import_helper, skip_if_sanitizer
from test.support import import_helper

_channels = import_helper.import_module('_interpchannels')
from concurrent.interpreters import _crossinterp
Expand Down Expand Up @@ -365,7 +365,6 @@ def test_shareable(self):
#self.assertIsNot(got, obj)


@skip_if_sanitizer('gh-129824: race on _waiting_release', thread=True)
class ChannelTests(TestBase):

def test_create_cid(self):
Expand Down
2 changes: 1 addition & 1 deletion Modules/_interpchannelsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,12 +511,12 @@ _waiting_release(_waiting_t *waiting, int received)
assert(!waiting->received);

waiting->status = WAITING_RELEASING;
PyThread_release_lock(waiting->mutex);
if (waiting->received != received) {
assert(received == 1);
waiting->received = received;
}
waiting->status = WAITING_RELEASED;
PyThread_release_lock(waiting->mutex);
}

static void
Expand Down
Loading