Skip to content

gh-131178: Add tests for ast command-line interface #133329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 11 commits into from
May 4, 2025
+168 −18
Merged

gh-131178: Add tests for ast command-line interface #133329

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
198c87a
Add tests for `ast` command-line interface
donbarbos May 3, 2025
bc12715
check unknown flag output
donbarbos May 3, 2025
75d3cb7
remove unused import
donbarbos May 3, 2025
de328af
Accept suggestions
donbarbos May 3, 2025
6aa5cd7
Accept suggestions
donbarbos May 4, 2025
b804f61
accept again
donbarbos May 4, 2025
21097eb
Rename from flags to flag
donbarbos May 4, 2025
42ff309
Rewrite tests with help messages
donbarbos May 4, 2025
ac71310
Remove normalize for result
donbarbos May 4, 2025
9f6f5b2
Update test_ast.py
donbarbos May 4, 2025
361706a
Update test_ast.py
donbarbos May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check unknown flag output
  • Loading branch information
@donbarbos
donbarbos committed May 3, 2025
commit bc12715b56572dc77eedb03df3bd0d2206df5a0a
9 changes: 5 additions & 4 deletions Lib/test/test_ast/test_ast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import copy
import dis
import enum
import io
import itertools
import os
import re
Expand All @@ -15,6 +14,7 @@
import types
import unittest
import weakref
from io import StringIO
from pathlib import Path
from textwrap import dedent
try:
Expand Down Expand Up @@ -3197,7 +3197,7 @@ def set_source(self, content):
f.write(self.text_normalize(content))

def invoke_ast(self, *flags):
output = io.StringIO()
output = StringIO()
with contextlib.redirect_stdout(output):
Comment thread
donbarbos marked this conversation as resolved.
Outdated
ast._main(args=[*flags, self.filename])
return self.text_normalize(output.getvalue())
Expand Down Expand Up @@ -3232,8 +3232,9 @@ def f(x):

with self.assertRaises(SystemExit):
Comment thread
donbarbos marked this conversation as resolved.
Outdated
# suppress argparse error message
with contextlib.redirect_stderr(io.StringIO()):
_ = self.invoke_ast('--unknown')
with contextlib.redirect_stderr(StringIO()):
output = self.invoke_ast('--unknown')
self.assertStartsWith(output, 'usage: ')

def test_mode_flag(self):
# test 'python -m ast -m/--mode'
Expand Down
Loading