Skip to content

gh-117657: Fix data race in new_reference for free-threaded build #129665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 2 commits into from
Feb 6, 2025
+8 −2
Merged

gh-117657: Fix data race in new_reference for free-threaded build #129665

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cb877b
fix the race
wrongnull Feb 4, 2025
d7cb09f
use _Py_THREAD_SANITIZER macro for performance reasons
wrongnull Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use _Py_THREAD_SANITIZER macro for performance reasons
  • Loading branch information
@wrongnull
wrongnull committed Feb 5, 2025
commit d7cb09fd4761e541070e551b2439f29ece31289a
9 changes: 8 additions & 1 deletion Objects/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2485,12 +2485,19 @@ new_reference(PyObject *op)
op->ob_refcnt = 1;
#endif
#else
_Py_atomic_store_uintptr_relaxed(&op->ob_tid, _Py_ThreadId());
op->ob_flags = 0;
op->ob_mutex = (PyMutex){ 0 };
#ifdef _Py_THREAD_SANITIZER
_Py_atomic_store_uintptr_relaxed(&op->ob_tid, _Py_ThreadId());
_Py_atomic_store_uint8_relaxed(&op->ob_gc_bits, 0);
_Py_atomic_store_uint32_relaxed(&op->ob_ref_local, 1);
_Py_atomic_store_ssize_relaxed(&op->ob_ref_shared, 0);
#else
op->ob_tid = _Py_ThreadId();
op->ob_gc_bits = 0;
op->ob_ref_local = 1;
op->ob_ref_shared = 0;
#endif
#endif
#ifdef Py_TRACE_REFS
_Py_AddToAllObjects(op);
Expand Down