gh-129005: Avoid copy in _pyio.FileIO.readinto#129006
Closed
cmaloney wants to merge 8 commits intopython:mainfrom
Closed
gh-129005: Avoid copy in _pyio.FileIO.readinto#129006cmaloney wants to merge 8 commits intopython:mainfrom
cmaloney wants to merge 8 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.readallocated and filled a buffer by callingread(2), than that data was copied into the user provied buffer. Read directly into the caller's buffer instead by usingos.readv.self.read()was doing the closed and readable checks so move those intoreadintoPR of
readintofirst as it is a lot smaller diff than thereadallcode but has the coreos.read->os.readvchange. Inmainhow the buffer is expanded between_io(new_buffersize) and_pyio(inline inread()) should get lined up.