Skip to content

gh-128400: Only show the current thread in faulthandler if the GIL is disabled #128425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 10 commits into from
Jan 3, 2025
Merged

gh-128400: Only show the current thread in faulthandler if the GIL is disabled #128425

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
95424ce
Only show the current thread while the GIL is disabled.
ZeroIntensity Jan 2, 2025
8d35bb6
Change the message.
ZeroIntensity Jan 2, 2025
aadadde
Fix tests.
ZeroIntensity Jan 2, 2025
170aa2a
Fix tests.
ZeroIntensity Jan 2, 2025
ed23233
Add documentation note.
ZeroIntensity Jan 2, 2025
5622f42
Add blurb
ZeroIntensity Jan 2, 2025
6089577
Remove garbage collector shenanigans.
ZeroIntensity Jan 2, 2025
b710acb
Be more clear in the docs.
ZeroIntensity Jan 2, 2025
b1677f3
Update faulthandler.c
ZeroIntensity Jan 2, 2025
11bb638
Update faulthandler.c
ZeroIntensity Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change the message.
  • Loading branch information
@ZeroIntensity
ZeroIntensity committed Jan 2, 2025
commit 8d35bb63a83d136009ba2fb33fc1d1639c05826f
2 changes: 1 addition & 1 deletion Modules/faulthandler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ faulthandler_dump_traceback(int fd, int all_threads,
else {
if (all_threads == FT_IGNORE_ALL_THREADS)
{
PUTS(fd, "<Only the current thread is shown while the GIL is disabled>\n");
PUTS(fd, "<Cannot show all threads while the GIL is disabled>\n");
}
if (tstate != NULL)
_Py_DumpTraceback(fd, tstate);
Expand Down