Skip to content

gh-128400: Stop-the-world when manually calling faulthandler #128422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 3 commits into from
Jan 2, 2025
Merged

gh-128400: Stop-the-world when manually calling faulthandler #128422

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8cf48a
gh-128400: Stop the world when calling manually
ZeroIntensity Jan 2, 2025
b9e4d48
Add blurb
ZeroIntensity Jan 2, 2025
b19d49f
Add a test.
ZeroIntensity Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-128400: Stop the world when calling manually
  • Loading branch information
@ZeroIntensity
ZeroIntensity committed Jan 2, 2025
commit a8cf48a886319c98b38ecb750b2c7a1299cb4ecd
5 changes: 5 additions & 0 deletions Modules/faulthandler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,12 @@ faulthandler_dump_traceback_py(PyObject *self,
return NULL;

if (all_threads) {
PyInterpreterState *interp = _PyInterpreterState_GET();
/* gh-128400: Accessing other thread states while they're running
* isn't safe if those threads are running. */
_PyEval_StopTheWorld(interp);
errmsg = _Py_DumpTracebackThreads(fd, NULL, tstate);
_PyEval_StartTheWorld(interp);
if (errmsg != NULL) {
PyErr_SetString(PyExc_RuntimeError, errmsg);
return NULL;
Expand Down