Skip to content

GH-127058: Make PySequence_Tuple safer and probably faster. #127758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 4 commits into from
Dec 11, 2024
Merged

GH-127058: Make PySequence_Tuple safer and probably faster. #127758

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b65fa75
Use a small buffer, then list when constructing a tuple from an abitr…
markshannon Dec 9, 2024
9e6b932
Add news
markshannon Dec 9, 2024
4b8caa0
Add test
markshannon Dec 11, 2024
8badf7b
Update Objects/abstract.c
markshannon Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test
  • Loading branch information
@markshannon
markshannon committed Dec 11, 2024
commit 4b8caa0e88908ecfed239a7251150e45cd960a14
25 changes: 25 additions & 0 deletions Lib/test/test_capi/test_tuple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import unittest
import sys
import gc
from collections import namedtuple
from test.support import import_helper

Expand Down Expand Up @@ -257,5 +258,29 @@ def test__tuple_resize(self):
self.assertRaises(SystemError, resize, [1, 2, 3], 0, False)
self.assertRaises(SystemError, resize, NULL, 0, False)

def test_bug_59313(self):
# Before 3.14, the C-API function PySequence_Tuple
# would create incomplete tuples which were visible to
# the cycle GC, and this test would crash the interpeter.
TAG = object()
tuples = []

def referrer_tuples():
return [x for x in gc.get_referrers(TAG)
if isinstance(x, tuple)]

def my_iter():
nonlocal tuples
yield TAG # 'tag' gets stored in the result tuple
tuples += referrer_tuples()
for x in range(10):
tuples += referrer_tuples()
# Prior to 3.13 would raise a SystemError when the tuple needs to be resized
yield x

self.assertEqual(tuple(my_iter()), (TAG, *range(10)))
self.assertEqual(tuples, [])


if __name__ == "__main__":
unittest.main()