Skip to content

gh-125206: Correct detection of complex numbers support in libffi #126104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 7 commits into from
Oct 30, 2024
Merged

gh-125206: Correct detection of complex numbers support in libffi #126104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9db50f0
gh-125206: Correct detection of complex numbers support in libffi
skirpichev Oct 29, 2024
5fdb838
+1
skirpichev Oct 29, 2024
06f937f
Merge branch 'main' into amend-libffi-complex-fix
skirpichev Oct 29, 2024
cbed501
+ WITH_SAVE_ENV
skirpichev Oct 29, 2024
66c1cf7
+formatting
skirpichev Oct 29, 2024
545f99f
address review: CFLAGS -> CPPFLAGS
skirpichev Oct 29, 2024
fc4ebff
address review: +LIBS
skirpichev Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review: CFLAGS -> CPPFLAGS
  • Loading branch information
@skirpichev
skirpichev committed Oct 29, 2024
commit 545f99fab2d202722b87ddd72ea2e848413b91fa
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4099,7 +4099,7 @@ AS_VAR_IF([have_libffi], [yes], [
#
AC_CACHE_CHECK([libffi has complex type support], [ac_cv_ffi_complex_double_supported],
[WITH_SAVE_ENV([
CFLAGS="$LIBFFI_CFLAGS $CFLAGS"
CPPFLAGS="$LIBFFI_CFLAGS $CPPFLAGS"
LDFLAGS="$LIBFFI_LIBS $LDFLAGS"
LIBS="$LIBFFI_LIBS"
Comment thread
skirpichev marked this conversation as resolved.
Outdated
AC_RUN_IFELSE([AC_LANG_SOURCE([[
Expand Down