gh-118423: Add INSTRUCTION_SIZE macro to code generator#125467
Merged
markshannon merged 34 commits intopython:mainfrom Oct 29, 2024
Merged
gh-118423: Add INSTRUCTION_SIZE macro to code generator#125467markshannon merged 34 commits intopython:mainfrom
INSTRUCTION_SIZE macro to code generator#125467markshannon merged 34 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not that familiar with the tier 1 interpreter (yet 😄 ) so I'd appreciate if someone could double check that for all
the places that use the new
INSTRUCTION_SIZEmacro, it is actually safe to do so.I replaced all examples of
next_instr - this_instr. There are still a few examples of1 + INLINE_CACHE_ENTRIES_...but I wasn't sure whether those were safe to change as well.I named the new macro
INSTRUCTION_SIZE, but I'm happy to change it toINSTRUCTION_LENGTHif you prefer.Feedback welcome :)
INSTRUCTION_SIZEmacro to code generator. #118423