Skip to content

[3.13] gh-122420: Fix accounting for immortal interned strings in refleak.py (GH-122421) #122430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 1 commit into from
Jul 30, 2024
Merged

[3.13] gh-122420: Fix accounting for immortal interned strings in refleak.py (GH-122421) #122430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-122420: Fix accounting for immortal interned strings in refleak.py (… 
…GH-122421)

The `_PyUnicode_Intern*` functions already adjust the total refcount, so
we don't want to readjust it in refleak.py.
(cherry picked from commit ac8da34)

Co-authored-by: Sam Gross <colesbury@gmail.com>
  • Loading branch information
@colesbury @miss-islington
colesbury authored and miss-islington committed Jul 29, 2024
commit 1b1daab557affacefd8f3289e48ba694bb28b504
2 changes: 1 addition & 1 deletion Lib/test/libregrtest/refleak.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def get_pooled_int(value):
# Use an internal-only keyword argument that mypy doesn't know yet
_only_immortal=True) # type: ignore[call-arg]
alloc_after = getallocatedblocks() - interned_immortal_after
rc_after = gettotalrefcount() - interned_immortal_after * 2
rc_after = gettotalrefcount()
fd_after = fd_count()

rc_deltas[i] = get_pooled_int(rc_after - rc_before)
Expand Down