Skip to content

[3.13] gh-117657: Skip tests that use threads after fork (GH-122194) #122198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colesbury merged 1 commit into from
Jul 23, 2024
Merged

[3.13] gh-117657: Skip tests that use threads after fork (GH-122194) #122198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-117657: Skip tests that use threads after fork (GH-122194) 
These tests fail when run under thread sanitizer due to the use of fork
and threads.
(cherry picked from commit 64e221d)

Co-authored-by: Sam Gross <colesbury@gmail.com>
  • Loading branch information
@colesbury @miss-islington
colesbury authored and miss-islington committed Jul 23, 2024
commit 34dcbb0342b8cbe3aacbefb5f5700a552d343fcb
3 changes: 3 additions & 0 deletions Lib/test/test_asyncio/test_unix_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1903,6 +1903,7 @@ async def test_fork_not_share_event_loop(self):
wait_process(pid, exitcode=0)

@hashlib_helper.requires_hashdigest('md5')
@support.skip_if_sanitizer("TSAN doesn't support threads after fork", thread=True)
def test_fork_signal_handling(self):
self.addCleanup(multiprocessing_cleanup_tests)

Expand Down Expand Up @@ -1949,6 +1950,7 @@ async def func():
self.assertTrue(child_handled.is_set())

@hashlib_helper.requires_hashdigest('md5')
@support.skip_if_sanitizer("TSAN doesn't support threads after fork", thread=True)
def test_fork_asyncio_run(self):
self.addCleanup(multiprocessing_cleanup_tests)

Expand All @@ -1968,6 +1970,7 @@ async def child_main():
self.assertEqual(result.value, 42)

@hashlib_helper.requires_hashdigest('md5')
@support.skip_if_sanitizer("TSAN doesn't support threads after fork", thread=True)
def test_fork_asyncio_subprocess(self):
self.addCleanup(multiprocessing_cleanup_tests)

Expand Down