Skip to content

GH-120754: Make PY_READ_MAX smaller than max byteobject size #121633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmaloney wants to merge 4 commits into from
Closed

GH-120754: Make PY_READ_MAX smaller than max byteobject size #121633

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a6e0ea
GH-120754: Make PY_READ_MAX fit in byteobject size
cmaloney Jul 11, 2024
c60ae27
Add news blurb
cmaloney Jul 11, 2024
da8b55c
tweak news
cmaloney Jul 17, 2024
1f4d053
tweak news more
cmaloney Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add news blurb
  • Loading branch information
@cmaloney
cmaloney committed Jul 11, 2024
commit c60ae273f130f74ee02f01e309f26901b1d2d046
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2024-07-11-13-57-50.gh-issue-120754.C1HedA.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Cap read size to smaller than the max BytesObject size. read() in POSIX
returns at most the number of requseted bytes, this updates python ``os.read``
to do similarly, and rather than throw an OverflowError in this case, return
a smaller than requseted byte object.
Copy link
Copy Markdown
Contributor Author

@cmaloney cmaloney Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested