Skip to content

GH-120754: Remove isatty call during regular open #121593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmaloney wants to merge 5 commits into from
Closed

GH-120754: Remove isatty call during regular open #121593

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36e9061
GH-120754: Remove isatty call during regular read
cmaloney Jul 10, 2024
a51e8ee
WASI sets st_blksize to 0, update _pyio to handle. _io already handled
cmaloney Jul 10, 2024
bc55828
Merge branch 'main' into cmaloney/stash_fstat_pr
cmaloney Jul 10, 2024
991fb01
Read must be smaller than _PY_READ_MAX
cmaloney Jul 10, 2024
a487c6b
Zipimport test relies on having a size > PY_READ_MAX meaning auto-exp…
cmaloney Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Zipimport test relies on having a size > PY_READ_MAX meaning auto-exp… 
…anding buffer
  • Loading branch information
@cmaloney
cmaloney committed Jul 11, 2024
commit a487c6bb7d3e8237f23fa7190fdd056f11ec8456
5 changes: 2 additions & 3 deletions Modules/_io/fileio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,8 +730,8 @@ _io_FileIO_readall_impl(fileio *self)
return err_closed();
}

if (self->stat_atopen != NULL) {
end = (Py_off_t)Py_MIN(self->stat_atopen->st_size, _PY_READ_MAX);
if (self->stat_atopen != NULL && self->stat_atopen->st_size < _PY_READ_MAX) {
end = (Py_off_t)self->stat_atopen->st_size;
}
else {
end = -1;
Expand Down Expand Up @@ -775,7 +775,6 @@ _io_FileIO_readall_impl(fileio *self)
}
}


result = PyBytes_FromStringAndSize(NULL, bufsize);
if (result == NULL)
return NULL;
Expand Down