Skip to content

gh-118908: Protect the REPL subprocess with a timeout in tests #120408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 2 commits into from
Jun 12, 2024
+6 −1
Merged

gh-118908: Protect the REPL subprocess with a timeout in tests #120408

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47e3511
gh-118908: Protect the REPL subprocess with a timeout in tests
pablogsal Jun 12, 2024
bc9bdc7
Update Lib/test/test_pyrepl/test_pyrepl.py
pablogsal Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Lib/test/test_pyrepl/test_pyrepl.py
  • Loading branch information
@pablogsal
pablogsal authored Jun 12, 2024
commit bc9bdc7da0df05d3e32ffe1307f191d4ec5c396a
1 change: 0 additions & 1 deletion Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,6 @@ def run_repl(self, repl_input: str | list[str], env: dict | None = None) -> tupl
try:
exit_code = process.wait(timeout=SHORT_TIMEOUT)
except subprocess.TimeoutExpired:
process.terminate()
process.kill()
exit_code = process.returncode
return "\n".join(output), exit_code