Feedback from Guido

python · JelleZijlstra · May 22, 2024 · May 21, 2024 · May 21, 2024 · May 21, 2024
commit d40a57730cb3bf4c31e0d6f919c02bd030010ab3
diff --git a/Include/internal/pycore_opcode_metadata.h b/Include/internal/pycore_opcode_metadata.h
diff --git a/Include/internal/pycore_uop_metadata.h b/Include/internal/pycore_uop_metadata.h
@@ -472,7 +472,7 @@ def _write_atomic(path, data, mode=0o666):
 #     Python 3.13a1 3568 (Change semantics of END_FOR)
 #     Python 3.13a5 3569 (Specialize CONTAINS_OP)
 #     Python 3.13a6 3570 (Add __firstlineno__ class attribute)
-#     Python 3.14a1 3571 (Add LOAD_COMMON_CONSTANT)
+#     Python 3.14a1 3600 (Add LOAD_COMMON_CONSTANT)
 
 #     Python 3.15 will start with 3700
 

diff --git a/Misc/NEWS.d/next/Core and Builtins/2024-05-21-12-17-02.gh-issue-119180.UNDUb9.rst b/Misc/NEWS.d/next/Core and Builtins/2024-05-21-12-17-02.gh-issue-119180.UNDUb9.rst
@@ -1,2 +1,2 @@
-Rename :opcode:`!LOAD_ASSERTION_ERROR` opcode to :opcode:`LOAD_COMMON_CONSTANT`
+Replace :opcode:`!LOAD_ASSERTION_ERROR` opcode with :opcode:`LOAD_COMMON_CONSTANT`
 and add support for :exc:`NotImplementedError`.
@@ -1198,9 +1198,7 @@ dummy_func(
                 value = PyExc_NotImplementedError;
                 break;
             default:
-                _PyErr_SetString(tstate, PyExc_SystemError,
-                                 "bad LOAD_COMMON_CONSTANT oparg");
-                ERROR_NO_POP();
+                Py_FatalError("bad LOAD_COMMON_CONSTANT oparg");
             }
         }
 

diff --git a/Python/ceval.c b/Python/ceval.c
@@ -9,7 +9,6 @@
 #include "pycore_cell.h"          // PyCell_GetRef()
 #include "pycore_ceval.h"
 #include "pycore_code.h"
-#include "pycore_compile.h"
 #include "pycore_emscripten_signal.h"  // _Py_CHECK_EMSCRIPTEN_SIGNALS
 #include "pycore_function.h"
 #include "pycore_instruments.h"

diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h