Skip to content

gh-118912: Remove description of issue fixed in 3.5 from autospeccing guide #119232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willingc merged 5 commits into from
May 20, 2024
Merged

gh-118912: Remove description of issue fixed in 3.5 from autospeccing guide #119232

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09b2503
Remove description of issue fixed in 3.5 from autospeccing guide
shaunagm May 20, 2024
71aabe8
Make autospeccing note text more succint and lint whitespace
shaunagm May 20, 2024
05b3d50
Add linting changes (missed in last commit)
shaunagm May 20, 2024
c7f90a6
Merge branch 'main' into update-mock-autospec-docs
shaunagm May 20, 2024
0b0ba7a
Merge branch 'main' into update-mock-autospec-docs
willingc May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add linting changes (missed in last commit)
  • Loading branch information
@shaunagm
shaunagm committed May 20, 2024
commit 05b3d500e2f24d5229007eba92204f0a8305eed6
8 changes: 4 additions & 4 deletions Doc/library/unittest.mock.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2585,12 +2585,12 @@ called incorrectly.
Before I explain how auto-speccing works, here's why it is needed.

:class:`Mock` is a very powerful and flexible object, but it suffers from a flaw which
is general to mocking. If you refactor some of your code, rename members and so on, any
tests for code that is still using the *old api* but uses mocks instead of the real
objects will still pass. This means your tests can all pass even though your code is
is general to mocking. If you refactor some of your code, rename members and so on, any
tests for code that is still using the *old api* but uses mocks instead of the real
objects will still pass. This means your tests can all pass even though your code is
broken.

.. versionchanged:: 3.5
.. versionchanged:: 3.5

Before 3.5, tests with a typo in the word assert would silently pass when they should
raise an error. You can still achieve this behavior by passing ``unsafe=True`` to Mock.
Expand Down