Skip to content

gh-117151: IO performance improvement, increase io.DEFAULT_BUFFER_SIZE to 128k #118144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 19 commits into from
Mar 7, 2025
+38 −22
Merged

gh-117151: IO performance improvement, increase io.DEFAULT_BUFFER_SIZE to 128k #118144

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1d85458
pythongh-117151: IO performance improvement, increase io.DEFAULT_BUFF…
rmmancom Feb 5, 2025
da988ba
construct the test data more efficiently, no intermediate list
rmmancom Feb 5, 2025
eaa0df6
adjust news and comments
rmmancom Feb 5, 2025
1af8e18
curly braces
rmmancom Feb 5, 2025
18f472c
cap the block size to 8 MB.
rmmancom Feb 5, 2025
d7e0cf7
use with to open file
rmmancom Feb 5, 2025
07be8af
cap the block size to 8 MB.
rmmancom Feb 5, 2025
8546600
add constant MAXIMUM_BUFFER_SIZE
rmmancom Feb 6, 2025
a1df21d
update docstring
rmmancom Feb 6, 2025
4e0e1e1
expose MAXIMUM_BUFFER_SIZE
rmmancom Feb 6, 2025
0ab4592
Revert "expose MAXIMUM_BUFFER_SIZE"
rmmancom Feb 7, 2025
209706e
rename to _MAXIMUM_BUFFER_SIZE
rmmancom Feb 7, 2025
7ce54c4
remove constant _MAXIMUM_BUFFER_SIZE
rmmancom Feb 10, 2025
4e9b68d
update news
rmmancom Feb 10, 2025
421ec33
Merge branch 'main' into io-buffer-size
morotti Feb 11, 2025
f7ecbef
move to after error
rmmancom Feb 18, 2025
54bc5ee
update news message to match code
rmmancom Feb 18, 2025
f9258be
format code block with double backticks
rmmancom Mar 7, 2025
3a78177
Merge branch 'main' into io-buffer-size
rmmancom Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cap the block size to 8 MB.
  • Loading branch information
@rmmancom
rmmancom committed Feb 6, 2025
commit 07be8afd18a03c8bac1181895c8914ae2b01fec8
2 changes: 1 addition & 1 deletion Lib/test/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def testDefaultBufferSize(self):

with self.open(TESTFN, 'rb') as f:
data = f.read1()
expected_size = max(blksize, io.DEFAULT_BUFFER_SIZE)
expected_size = max(min(blksize, 8192 * 1024), io.DEFAULT_BUFFER_SIZE)
self.assertEqual(len(data), expected_size)

def testTruncateOnWindows(self):
Expand Down