Skip to content

gh-117431: Adapt bytes and bytearray .startswith() and .endswith() to Argument Clinic #117495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 11 commits into from
Apr 3, 2024
Merged

gh-117431: Adapt bytes and bytearray .startswith() and .endswith() to Argument Clinic #117495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2c789a9
Adapt byte*.startswith
erlend-aasland Apr 2, 2024
132080c
Adapt byte*.endswith
erlend-aasland Apr 2, 2024
b7f04d7
Optimise
erlend-aasland Apr 2, 2024
57c9afc
Add NEWS
erlend-aasland Apr 3, 2024
1b89eb9
Adjust docstring
erlend-aasland Apr 3, 2024
fabe761
Docstring: Use 'bytes' or 'bytearray' instead of 'byte string'
erlend-aasland Apr 3, 2024
e9b59cc
Docstring: Remove unneeded body from bytearray.startswith; the param …
erlend-aasland Apr 3, 2024
655a6a8
Regen clinic
erlend-aasland Apr 3, 2024
f5fb40b
Pull in main
erlend-aasland Apr 3, 2024
2c54b79
Address Inada-san's review: endswith's first param is named 'suffix'
erlend-aasland Apr 3, 2024
2443309
Address Inada-san's review: indent clinic input and consistently use …
erlend-aasland Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Regen clinic
  • Loading branch information
@erlend-aasland
erlend-aasland committed Apr 3, 2024
commit 655a6a88fed9035838e9fe389766024f22568c29
2 changes: 1 addition & 1 deletion Objects/bytearrayobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,7 +1204,7 @@ Return True if the bytearray starts with the specified prefix, False otherwise.
static PyObject *
bytearray_startswith_impl(PyByteArrayObject *self, PyObject *subobj,
Py_ssize_t start, Py_ssize_t end)
/*[clinic end generated code: output=a3d9b6d44d3662a6 input=1bb77e6e964116b5]*/
/*[clinic end generated code: output=a3d9b6d44d3662a6 input=5815c1138cf1ba28]*/
{
return _Py_bytes_startswith(PyByteArray_AS_STRING(self), PyByteArray_GET_SIZE(self),
subobj, start, end);
Expand Down
8 changes: 2 additions & 6 deletions Objects/clinic/bytearrayobject.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.