Skip to content

gh-111968: Use per-thread freelists for dict in free-threading #114323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 25 commits into from
Feb 1, 2024
+75 −75
Merged

gh-111968: Use per-thread freelists for dict in free-threading #114323

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
8561efc
gh-111968: Use per-thread freelists for dict in free-threading
corona10 Jan 19, 2024
6a69d6f
Address code review
corona10 Jan 19, 2024
b2d4606
Update Objects/dictobject.c
corona10 Jan 19, 2024
8889072
nit
corona10 Jan 19, 2024
0cecf66
Remove duplicated DICT_MAX_WATCHERS
corona10 Jan 19, 2024
7041d4a
nit
corona10 Jan 19, 2024
e973352
Address code review
corona10 Jan 20, 2024
514a66f
Remove unnecessary changes
corona10 Jan 20, 2024
c731cd3
Merge remote-tracking branch 'upstream/main' into gh-111968-dict
corona10 Jan 24, 2024
ef2b754
Address code review
corona10 Jan 26, 2024
e038141
Fix slash
corona10 Jan 26, 2024
e808bab
Address code review
corona10 Jan 26, 2024
d5fbbea
Merge remote-tracking branch 'upstream/main' into gh-111968-dict
corona10 Jan 26, 2024
e91d8ff
Address code review
corona10 Jan 26, 2024
b905692
Address code review
corona10 Jan 26, 2024
4f7d921
Address code review
corona10 Jan 26, 2024
9239cdc
Address code review
corona10 Jan 26, 2024
c12b1c1
Improve comments
corona10 Jan 26, 2024
ccd3b24
Address code review
corona10 Jan 26, 2024
9eff9a9
Merge remote-tracking branch 'upstream/main' into gh-111968-dict
corona10 Jan 30, 2024
e1d9549
nit
corona10 Jan 30, 2024
4a76399
Revert _PyDict_Fini
corona10 Feb 1, 2024
11f81d1
fix
corona10 Feb 1, 2024
86e3228
Address code review
corona10 Feb 1, 2024
42a3541
fix
corona10 Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Objects/dictobject.c 
Co-authored-by: Sam Gross <colesbury@gmail.com>
  • Loading branch information
@corona10 @colesbury
corona10 and colesbury authored Jan 19, 2024
commit b2d4606a254ed5b10c46329c4a6aed18d3720c16
4 changes: 3 additions & 1 deletion Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2467,7 +2467,9 @@ dict_dealloc(PyObject *self)
}
#ifdef WITH_FREELISTS
struct _Py_dict_state *state = get_dict_state();
if (state->numfree < PyDict_MAXFREELIST && state->numfree >=0 && Py_IS_TYPE(mp, &PyDict_Type)) {
if (state->numfree < PyDict_MAXFREELIST && state->numfree >=0 &&
Py_IS_TYPE(mp, &PyDict_Type))
{
state->free_list[state->numfree++] = mp;
OBJECT_STAT_INC(to_freelist);
}
Expand Down