Skip to content

[3.11] gh-110378: Close invalid generators in contextmanager and asynccontextmanager (GH-110499) #110589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 2 commits into from
Oct 10, 2023
Merged

[3.11] gh-110378: Close invalid generators in contextmanager and asynccontextmanager (GH-110499) #110589

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad7dcbb
gh-110378: Close invalid generators in contextmanager and asynccontex…
serhiy-storchaka Oct 10, 2023
1a5db70
Remove asserts using `ag_suspended`
ambv Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove asserts using ag_suspended
  • Loading branch information
@ambv
ambv committed Oct 10, 2023
commit 1a5db70ddcbe62729ae992fe58a9050d3a89bdbd
6 changes: 0 additions & 6 deletions Lib/test/test_contextlib_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,6 @@ async def whoo():
await ctx.__aenter__()
with self.assertRaises(RuntimeError):
await ctx.__aexit__(TypeError, TypeError('foo'), None)
if support.check_impl_detail(cpython=True):
# The "gen" attribute is an implementation detail.
self.assertFalse(ctx.gen.ag_suspended)

@_async_test
async def test_contextmanager_trap_no_yield(self):
Expand All @@ -228,9 +225,6 @@ async def whoo():
await ctx.__aenter__()
with self.assertRaises(RuntimeError):
await ctx.__aexit__(None, None, None)
if support.check_impl_detail(cpython=True):
# The "gen" attribute is an implementation detail.
self.assertFalse(ctx.gen.ag_suspended)

@_async_test
async def test_contextmanager_non_normalised(self):
Expand Down