Skip to content

gh-106922: Support multi-line error locations in traceback #109589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
williamwen42 wants to merge 14 commits into from
Closed

gh-106922: Support multi-line error locations in traceback #109589

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
20da582
update traceback.c
williamwen42 Jul 27, 2023
2e63abc
update tests and traceback.py
williamwen42 Jul 29, 2023
db094ed
wip more updates to traceback.c
williamwen42 Aug 3, 2023
5d8ceff
wip more updates to traceback.c
williamwen42 Aug 18, 2023
f35d975
wip done initial traceback.c implementation
williamwen42 Sep 13, 2023
9d02a5c
initial review
williamwen42 Sep 15, 2023
91fcb73
fix issues - get tests passing
williamwen42 Sep 18, 2023
d155d35
add function call traceback tests
williamwen42 Sep 18, 2023
7bee8ba
add more tests
williamwen42 Sep 18, 2023
34a5755
make outputs abbreviated, only output 1 line when location informatio…
williamwen42 Sep 19, 2023
2fcbea7
fix other failing tests
williamwen42 Sep 19, 2023
e4b978d
fix smelly symbol
williamwen42 Sep 20, 2023
26fd2d9
small fixes
williamwen42 Sep 21, 2023
bd8a837
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix smelly symbol
  • Loading branch information
@williamwen42
williamwen42 committed Sep 20, 2023
commit e4b978ddc34f793fea18e6145996b4269f7fd69f
3 changes: 2 additions & 1 deletion Python/traceback.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,8 @@ _Py_DisplaySourceLine(PyObject *f, PyObject *filename, int lineno, int indent,
*/

// helper functions for anchor extraction
const char *_get_segment_str(PyObject *segment_lines, Py_ssize_t lineno, Py_ssize_t *size)
static const char
*_get_segment_str(PyObject *segment_lines, Py_ssize_t lineno, Py_ssize_t *size)
{
return PyUnicode_AsUTF8AndSize(PyList_GET_ITEM(segment_lines, lineno), size);
}
Expand Down