Skip to content

gh-106581: Add 10 new opcodes by allowing assert(kwnames == NULL) #106707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 5 commits into from
Jul 17, 2023
Merged

gh-106581: Add 10 new opcodes by allowing assert(kwnames == NULL) #106707

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9d070f
Allow using 'kwnames' -- this adds 14 new opcodes
gvanrossum Jul 13, 2023
a341d14
Don't actually allow using kwnames in Tier 2
gvanrossum Jul 14, 2023
35a1bb7
Remove unneeded block
gvanrossum Jul 17, 2023
d02117d
Merge branch 'main' into simple-calls
gvanrossum Jul 17, 2023
eacb086
Drop debug output
gvanrossum Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow using 'kwnames' -- this adds 14 new opcodes 
Not all of these are useful, but I think they all work.
It leaves another 14 CALL specializations that need to be split
(or need gh-106603, allowing oparg *and* one cache entry per uop).
  • Loading branch information
@gvanrossum
gvanrossum committed Jul 15, 2023
commit b9d070f4be45375c4f07f288df9eb2474e8bc92c
14 changes: 14 additions & 0 deletions Include/internal/pycore_opcode_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2746,6 +2746,8 @@ _PyUopExecute(_PyExecutorObject *executor, _PyInterpreterFrame *frame, PyObject
int opcode;
uint64_t operand;
int oparg;
PyObject *kwnames = NULL; // Borrowed reference. Reset by CALL instructions.

for (;;) {
opcode = self->trace[pc].opcode;
operand = self->trace[pc].operand;
Expand Down
Loading